search

pa11y / pa11y-ci

Pa11y CI is a CI-centric accessibility test runner, built using Pa11y
https://pa11y.org
GNU Lesser General Public License v3.0
509 stars 62 forks source link

Add JavaScript config example to README #197

Closed aarongoldenthal closed 8 months ago

aarongoldenthal commented 1 year ago

Update README to include additional details and example with JavaScript config file, including how it can be used to dynamically update config. Based on question from https://github.com/pa11y/pa11y-ci/issues/193.

aarongoldenthal commented 1 year ago

The GitHub actions failures seem to be caused by ubuntu-latest moving to v22.04, per https://github.com/pa11y/pa11y/issues/651 and https://github.com/pa11y/pa11y/issues/662 (they tests all pass if pinning to ubuntu-20.04, although that's obviously not a long-term fix).

danyalaytekin commented 8 months ago

@aarongoldenthal Hello again! Thanks for this contribution too. As I mentioned I'd like to merge it into main before we publish v3.1.0. I've made two commits with tweaks which are described by their commit names above - please let me know whether you think they're ok or would like me to revert them, or for us to make further changes.

P.S. About your pinning comment - as you've probably noticed, I have settled for the pinning for now, for these minor-level updates, although I'm working to describe the chromeLaunchConfig workaround consistently across repos. Normal *-latest service will return with the next major version of each project.

aarongoldenthal commented 8 months ago

@aarongoldenthal Hello again! Thanks for this contribution too. As I mentioned I'd like to merge it into main before we publish v3.1.0. I've made two commits with tweaks which are described by their commit names above - please let me know whether you think they're ok or would like me to revert them, or for us to make further changes.

@danyalaytekin LGTM