search

pa11y / pa11y-ci

Pa11y CI is a CI-centric accessibility test runner, built using Pa11y
https://pa11y.org
GNU Lesser General Public License v3.0
509 stars 62 forks source link

Ignore config urls when using sitemap #230

Closed mkotamies closed 3 months ago

mkotamies commented 6 months ago

Bug report about the problem.

Readme states that Providing a sitemap will cause the urls property in your JSON config to be ignored. but the code doesn't work as expected.

I have prepared a change that sets config urls to empty array when sitemap is provided. Change includes also a test case that was missing before.

danyalaytekin commented 3 months ago

Thanks for this contribution @mkotamies! I confess I forgot it was a partner to the issue you raised, before I started working on adding a test tonight 🤦🏻‍♂️ I'll add you as a coauthor to those commits (if you'd like to be removed as co-author though for any reason please let me know). I've just reread @aarongoldenthal's extra findings as well, so I realise we could go quite a bit further with these tests, but for now will focus on clarifying "they combine" or "they don't combine".

danyalaytekin commented 3 months ago

Work continuing in: