search

pa11y / pa11y-ci

Pa11y CI is a CI-centric accessibility test runner, built using Pa11y
https://pa11y.org
GNU Lesser General Public License v3.0
520 stars 63 forks source link

[WIP] Share browser instance between test runs #47

Closed andrewmee closed 6 years ago

andrewmee commented 6 years ago

Launching a single Chrome instance to be shared between tests.

This instance will use the default chromeLaunchConfig options only, and not respond to any per-url chromeLaunchConfig.

Todo:

rowanmanning commented 6 years ago

I don't think we need to be as clever as this – each browser can have multiple pages, so as long as we're happy with the number of concurrent pages being tested then we should only ever need one browser instance. Maybe talk through on Slack tomorrow if we get time?

edit: oh I see you're trying to ensure each URL can have its own Chrome launch config? I'm tempted to say that we enforce a restriction on Pa11y CI that each URL must use the same launch config but that's up for discussion. E.g. would you want different pages to ignore or not ignore HTTPs errors, or use a completely different Chrome version?

andrewmee commented 6 years ago

Yeah let's discuss. As you guessed I was doing this as I thought it would be important to allow people to have different urls using different Chrome launch config (specifically the various Chrome flags and in particular window-size).

I can definitely see that coming in handy for people (and it seems a relatively painless thing for us to implement) but there may be other ways around it too; like only allowing chromeLaunchConfig in the default options, in which case if people wanted variations they could run CI multiple times using different configs/sitemaps I guess.

rowanmanning commented 6 years ago

This all seems good, gonna merge into 2.x ready for launch. The unit tests are still at ~100% so happy to just improve coverage later if we need to.