search

pa11y / pa11y-ci

Pa11y CI is a CI-centric accessibility test runner, built using Pa11y
https://pa11y.org
GNU Lesser General Public License v3.0
525 stars 63 forks source link

Capture Screen Per URL in a sitemap #74

Open umutphp opened 5 years ago

umutphp commented 5 years ago

The "screenCapture" option should be set under "config.defaults" array when a sitemap is used.

The value should contain "filename" and It will be replaced with a string created from URL.

Closes #72

umutphp commented 5 years ago

Great work, thanks for contributing. Can you add a unit-test for your change? Then this looks great

By the way, I did not add the unit-test yet.

Mschuddings commented 1 year ago

Can this also be used for for a list of urls?

for example: { "defaults": { "reporters": [ "cli", "pa11y-reporter-html" ], "screenCapture": "pa11y/filename.png" }, "urls": [ "https://www.example.be/", "https://www.example.be/nl",

In stead of specfying for each URL a screenCapture url.

umutphp commented 1 year ago

Can this also be used for for a list of urls?

for example: { "defaults": { "reporters": [ "cli", "pa11y-reporter-html" ], "screenCapture": "pa11y/filename.png" }, "urls": [ "https://www.example.be/", "https://www.example.be/nl",

In stead of specfying for each URL a screenCapture url.

@Mschuddings I do not remember what I did for this MR :)

kramar commented 6 months ago

Is there a chance that this PR will be merged?

danyalaytekin commented 6 months ago

Hi @kramar, thanks for following up! Sooo reading through this conversation, it looks like the team approved the general idea, but we'll need some test coverage first. From my own point of view I'm not sure we need filenamify. Adding to future milestone for now.

btabaska commented 4 months ago

This is an issue for a project that I am working on. We currently use sitemap.xml and would like artifacts from every page scanned. However, the current logic of the application using a JSON config file makes it so that every screenshot is saved to the same file name when an action is run. Is there any work that can be done on this to get this PR across the finish line?

umutphp commented 4 months ago

@btabaska 5 years ago I have created the PR but I don know why I could not finalize it. Now, I am not able to write the tests and finalize it.

@joeyciechanowicz Is it possible for you to take action on this PR?