search

pa11y / pa11y-dashboard

Pa11y Dashboard is a web interface which helps you monitor the accessibility of your websites
https://pa11y.org
GNU General Public License v3.0
983 stars 181 forks source link

Skip Rules Link #303

Closed cmuncharaz closed 2 years ago

cmuncharaz commented 2 years ago

This is only a proposal to fix one of the issues identified the Pa11y Dashboard accessibility check. Please, feel free to accept it, amend it, or reject it.

cmuncharaz commented 2 years ago

Here's more info on the pull request: The Pa11y Dashboard edit page includes a long list of rules to ignore. In the visual presentation, the display of this list is limited to a fixed height with a scroll bar, so the user only sees a few rules in the list. However, the keyboard user needs to tab through all that long list to reach the submit button. This pull request introduces a link to skip the rules list (only visible on keyboard focus) to improve keyboard user experience. However, a collapsible element to show and hide the list of rules might be a better solution. Please, feel free to discuss it.

jpw commented 2 years ago

LGTM, thanks! Usually we would not check generated files into git such as public/css/site.min.css, but that can be thought about in a different PR in the future.