Closed paulh002 closed 11 months ago
Hi Paul,
The radioberry is based on soapysdr.
You are talking to remvove:
double getBandwidth( const int direction, const size_t channel ) const;
std::vector
The only remark i have to make : do we not break the idea of a generic soapy interface wich expects these methods?
73 Johan
If you don't overload the functions SoapySDR will just return empty vectors. Or we can keep the functions and return empty vector, this is how I did it now.
Right now I can only test it with my own software, normally you choose a bandwidth which is lower than the half the sample rate. It is not such an issue, I will try to test it with some other generic software to see if it works.
73, Paul
Op zo 29 mei 2022 om 10:06 schreef Johan @.***>:
Hi Paul,
The radioberry is based on soapysdr.
You are talking to remvove: double getBandwidth( const int direction, const size_t channel ) const; std::vector listBandwidths( const int direction, const size_t channel ) const;
The only remark i have to make : do we not break the idea of a generic soapy interface wich expects these methods?
73 Johan
— Reply to this email directly, view it on GitHub https://github.com/pa3gsb/Radioberry-2.x/issues/28#issuecomment-1140399426, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIOBYUEAOUIQV3ISSY2VIIDVMMQR7ANCNFSM5XGKRUCQ . You are receiving this because you authored the thread.Message ID: @.***>
Paul,
Returning empty list make sense... user of the api can remove or disable the option of selecting the bandwith.
73 Johan
Hi All,
The current SoapyRadioberry driver returns a number of bandwidth which are the same as the sampling frequencies. If I compare this with other SoapySDR drivers than this is not correct. For example Sdrplay uses bandwidth to indicate the filter options that are placed after the frontend mixer. Because radioberry does not use a frontend mixer, my suggesten is to remove all bandwidths from de Soapyradioberry driver. If this is fine, I will issue a pull request.