search

paambaati / codeclimate-action

GitHub Action to send your code coverage to CodeClimate
MIT License
200 stars 63 forks source link

Does not run on macos-14 #744

Closed isaachinman closed 3 months ago

isaachinman commented 5 months ago

This action does not successfully run on the hosted macos-14 runners.

I get the following error:

/Users/runner/work/_actions/paambaati/codeclimate-action/v5.0.0/lib/utils.js:58
                throw new Error(`Download of '${url}' failed with response status code ${response.status}`);
Error: 🚨 CC Reporter download failed!
                      ^
Error: Download of 'https://codeclimate.com/downloads/test-reporter/test-reporter-latest-darwin-arm64' failed with response status code 403
    at /Users/runner/work/_actions/paambaati/codeclimate-action/v5.0.0/lib/utils.js:58:23
isaachinman commented 5 months ago

@paambaati Would love to see this fixed ASAP and am happy to help. Otherwise we will need to switch away to another CodeClimate action, or write our own. There are hosted darwin builds for OSX.

isaachinman commented 5 months ago

The key problem here is arm64 vs amd64. Actually, I wonder if this is a CodeClimate limitation?

paambaati commented 5 months ago

It is indeed a CC limitation; see https://github.com/paambaati/codeclimate-action/blob/749a6d38dd25db47aba7d93e78a60a6bff6df89f/test/integration.test.ts#L14-L20

rogerluan commented 3 months ago

@paambaati I see the integration test code above, but it's actually failing instead of skipping, is this expected? E.g.:

image

https://github.com/rogerluan/arkana/actions/runs/9431336943/job/25979873736

paambaati commented 3 months ago

@rogerluan This is expected, because CodeClimate does not publish ARM64 images — see https://github.com/codeclimate/test-reporter

I will make sure there’s a more obvious error message in the next release.

rogerluan commented 3 months ago

My bad, I thought the code above was a check in the runtime code that would print that message in case it was running on macOS, but it's just an integration test, not the actual code right 😅

I guess I'll have to build for linux if I want to upload code coverage then 😬 since it looks like they're not interested in fixing that.

Thanks @paambaati

paambaati commented 3 months ago

Please upgrade to v8.0.0 of this action and you should be able to see a more obvious error when using an unsupported environment.