pablo-co / bamboo_postmark

A Bamboo adapter for Postmark
MIT License
39 stars 29 forks source link

put_params to put_params #15

Closed guidoholz closed 7 years ago

guidoholz commented 7 years ago

Hi

in your example of additional parameters you should change put_paramS to put_param.

Another interesting point is, how you can add attachments with put_param

e.g. could be:

email
|> Bamboo.PostmarkHelper.put_param("Attachments",
   [
     %{
       Name: file.txt,
       Content: "/some/file.txt" |> File.read!() |> Base.encode64(),
       ContentType: "txt"
     }
   ])

it took a bit to figure out :)

thanks for the package!

pablo-co commented 7 years ago

Thanks for pointing out the typo. Your file example is definitely something not trivial to figure out, I'll make sure to add it to the README. Thank you!