Allow reading api key from system environment variable

pablo-co / bamboo_postmark

A Bamboo adapter for Postmark

MIT License

39 stars 29 forks source link

Allow reading api key from system environment variable #24

Closed junjizhi closed 5 years ago

junjizhi commented 5 years ago

Fixed https://github.com/pablo-co/bamboo_postmark/issues/25

Borrowing the logic from sendgrid adapter: https://github.com/thoughtbot/bamboo/blob/34cd76df94ca58bf75c8e442178de9db7fac75f3/lib/bamboo/adapters/send_grid_adapter.ex#L66-L70

pablo-co commented 5 years ago

Hello, @junjizhi! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

pablo-co commented 5 years ago

The code in this PR didn't work. So I implemented it on #26.