search

pablo-co / bamboo_postmark

A Bamboo adapter for Postmark
MIT License
39 stars 29 forks source link

Support for template alias #28

Closed mustela closed 3 years ago

mustela commented 5 years ago

Hello there!

Is there already any plan to support TemplateAlias para instead of templateID?

Thanks!

pablo-co commented 5 years ago

It looks like something we should support. I'll look into this during the weekend.

mustela commented 5 years ago

Hey @pablo-co have you started to work on it? If not, happy to work on it, if you give me some guidance. I guess I could duplicate this method https://github.com/pablo-co/bamboo_postmark/blob/master/lib/bamboo/postmark_helper.ex#L34, and replace template_id with a map like {template_alias: xx}.

Let me know if you have any thoughts. Thanks!

pablo-co commented 4 years ago

I've been having some really busy weeks. Let me think this through as I want to make sure whatever we choose to implement is the right interface to expose.

mustela commented 4 years ago

No problem! Happy to work on it if you want to.

mustela commented 4 years ago

Hey @pablo-co is there any plan for this? I can try if this is not in your plans.

pablo-co commented 4 years ago

@mustela feel free to do so! I've been unable to find the time to do so. 👍