search

pablo-co / bamboo_postmark

A Bamboo adapter for Postmark
MIT License
39 stars 29 forks source link

Add reply_to/2 function #30

Closed preciz closed 4 months ago

preciz commented 5 years ago

I required a reply_to function and found one of the forks already implemented it.

Also a quick note about bamboo_postmark/test/: The "Reply-To" header tests are a bit misleading since the code below will cause a Postmark API error because "Reply-To" header is not allowed.

put_header("Reply-To", "email@example.com")
pablo-co commented 4 years ago

This functionality is already covered by put_param/2: put_param("Reply-To", "email@example.com"). I'll leave this PR open for now. Have to take some time to look into how people are using this library, to expose the most used functions as named helpers such as this.

preciz commented 4 years ago

Until then this line should be changed cause it causes an error in production: https://github.com/pablo-co/bamboo_postmark/blob/99dfa0fe2f1a9b20a2678601ea21608292b29962/test/lib/bamboo/postmark_adapter_test.exs#L145

Also the put_param("Reply-To", "email@example.com") solution should be documented.

Should I open a PR for these?