pablo-s / passes

Manage your digital passes
GNU General Public License v3.0
66 stars 16 forks source link

Build fails due to appstream metadata validation failure #18

Closed a-wai closed 1 year ago

a-wai commented 1 year ago

Appstream metadata validation fails, mostly due to the screenshot being invalid. Here's the relevant output:

==================================== 2/2 =====================================
test:         Validate appstream file
start time:   13:44:34
duration:     0.56s
result:       exit status 1
command:      MALLOC_PERTURB_=48 /usr/bin/appstream-util validate data/me.sanchezrodriguez.passes.metainfo.xml
----------------------------------- stdout -----------------------------------
data/me.sanchezrodriguez.passes.metainfo.xml: FAILED:
• attribute-invalid     : <screenshot> width too large [https://raw.githubusercontent.com/pablo-s/passes/main/data/screenshots/passes.png] maximum is 1600px
• attribute-invalid     : <screenshot> height too large [https://raw.githubusercontent.com/pablo-s/passes/main/data/screenshots/passes.png] maximum is 900px
• style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/pablo-s/passes/main/data/screenshots/passes.png]
• style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/pablo-s/passes/main/data/screenshots/passes.png]
• style-invalid         : <ul> cannot start a description [(null)]
• style-invalid         : Not enough <p> tags for a good description [0/1]
----------------------------------- stderr -----------------------------------
Validation of files failed
==============================================================================

Note: this happened on Debian testing using appstream-util version 0.8.1

pablo-s commented 1 year ago

Hello @a-wai ! I have just fixed the reported errors in commits 5eae3fbadcaafa26bcc92b91783700a84abed903 and 4b0c443f555a32609038c221a0f200ecfdc10380. Thanks!

a-wai commented 1 year ago

Perfect, thanks for the quick fix :)