search

pablo-s / passes

Manage your digital passes
GNU General Public License v3.0
70 stars 15 forks source link

Improve string format and crediting of contributors #39

Closed turtlegarden closed 1 month ago

turtlegarden commented 10 months ago

Note: I was sadly unable to recompile the po files after I had made these changes due to a dependency issue. Once you recompile them, I can credit the translators properly and add a Swedish translation.

pablo-s commented 10 months ago

Thanks to both of you for the time spent on improving Passes!

If I am not mistaken, these are the changes proposed in this pull request: (1) add contributors, (2) formatting Blueprint and Python files, (3) changes in some texts, (4) development profile.

I really like the change 1. Especially using the changes proposed by @TheEvilSkeleton .

I am not sure I want number 2. But please, let me know if I am missing something. Why is it better this other format? In general, I do prefer having the opening curly bracket in its own line.

About number 3, is it better to capitalize all words in sentences? Is "Import A Pass" is better than "Import a pass"?

Regarding change 4, it may be that it brings something useful, such as the devel header bar. But, apart from this, what other benefits will it bring?

turtlegarden commented 10 months ago

Hello, and thank you for your quick response!

If I am not mistaken, these are the changes proposed in this pull request: (1) add contributors, (2) formatting Blueprint and Python files, (3) changes in some texts, (4) development profile.

Those are indeed the changes added.

I am not sure I want number 2. But please, let me know if I am missing something. Why is it better this other format? In general, I do prefer having the opening curly bracket in its own line.

This formatting is automatically done by blueprint-compiler format, if wanted I can put the braces on the new line, but the automatic tool does not so for the time being I've left it that way. :)

About number 3, is it better to capitalize all words in sentences? Is "Import A Pass" is better than "Import a pass"?

In areas like where that string is used, the GNOME HIG reccomends header capitalization (although now I've realized I've slightly incorrectly formatted that string).

Regarding change 4, it may be that it brings something useful, such as the devel header bar. But, apart from this, what other benefits will it bring?

It brings consistent versioning throughout the app, that only needs to be updated from the root meson.build, and as well introduces changes that will allow other values to easily be set at buildtime. This also allows the new troubleshooting info to show more information regarding if the app was built for a release or as a development experiment.

turtlegarden commented 10 months ago

I've fixed the files, thank you for clarifying your preference!

pablo-s commented 10 months ago

Thank you @turtlegarden !

I am still not sure about the re-formating of the code. Either Python or Blueprint files. However, I will consider using formatters in the future.

Regarding the rest of the changes, I think I would be happy with them. Is it fine with you creating independent pull requests for each set of changes? I think it is too much for a single one.

turtlegarden commented 10 months ago

I am unsure if I can split the commit histories, as many of them are very much based on one another. But I can try. Unfortunately, I don't have time to reimplement them all in seperate pull requests.