Minor while loop refactor to make it more explicit

pablobuenaposada / HonDash

Dashboard for Hondata K-Pro & S300 ECUs

GNU Affero General Public License v3.0

66 stars 29 forks source link

Minor while loop refactor to make it more explicit #119

Closed AndreMiras closed 4 years ago

AndreMiras commented 4 years ago

explicit stop condition
explicit error catching

pablobuenaposada commented 4 years ago

❤️❤️❤️❤️ tested in the device and everything works as expected. would make sense instead of app_started call it something like websocket_started?

AndreMiras commented 4 years ago

Thanks for the review, I don't have strong opinion about the naming, both are equally fine for me. I've renamed to websocket_started as per your suggestion.

pablobuenaposada commented 4 years ago

Thanks for the review, I don't have strong opinion about the naming, both are equally fine for me. I've renamed to websocket_started as per your suggestion.

meged!