React arj

[pablobuenaposada]

what happened @AdamRJonesHPD ?

[AdamRJonesHPD]

what happens @AdamRJonesHPD ?

I made a mess out of things, then didn't look at it for a couple of months, then decided to blow it out and try to re-learn everything! I couldn't even understand my own notes anymore.

I had all available values streaming over the websocket but somehow ended up back at the base packet. Trying to sort that out now and I might get back into trying to build a react app

[pablobuenaposada]

that would be awesome, I see you added analog ports too, I will double-check them and try to add them to the project in the next days

[AdamRJonesHPD]

My injduty formula is jacked but I will sort that out later.

What is your process for adding fields? This is how I approached...

Backend/devices:

• add to constants.py
• add properties to s300.py

Backend/setup_validator:

• add fields to constants.py
• add fields to schema (I don't think this affected what I could see over the ws)

Backend:

• add properties to ecu.py
• add fields to main.py

am I missing a step?

[pablobuenaposada]

that seems correct to me! I would suggest to make only a pull request adding one new value and the we figure out all is needed with a smaller scope