search

pablobuenaposada / HonDash

Dashboard for Hondata K-Pro & S300 ECUs
GNU Affero General Public License v3.0
66 stars 29 forks source link

All s300 vals #219

Open AdamRJonesHPD opened 3 years ago

AdamRJonesHPD commented 3 years ago

@pablobuenaposada

Contains all S300v3 fields that I've been able to decode. Was having trouble showing all fields, a restart/rebuild fixed it.

All fields added were stimulated on the engine sim. I reserve the right to keep working on the conversion formulas :)

Please have a look and let me know your thoughts!

AdamRJonesHPD commented 3 years ago

"The other thing is there are too many commits, normally you will expect only one commit per pull request, here we have around 30 with reverts in the middle that if I would merge it like this is going to pollute the git history."

I'm good with this suggestion. What's the proper etiquette here? If I'm working on a branch for a while it's going to have at least a few commits. Do I finish, merge that branch back my master, and then submit a PR for the whole thing?

Regarding paring down to only one added field, should I stash my larger changes locally, or just comment out the others until we are ready to roll them in?

pablobuenaposada commented 3 years ago

"The other thing is there are too many commits, normally you will expect only one commit per pull request, here we have around 30 with reverts in the middle that if I would merge it like this is going to pollute the git history."

I'm good with this suggestion. What's the proper etiquette here? If I'm working on a branch for a while it's going to have at least a few commits. Do I finish, merge that branch back my master, and then submit a PR for the whole thing?

There's a way to squash commits before pull requesting, check google because is better explained there than I could do. The idea is that you can do as many commits as you want locally for your clarity but just before pull requesting you squash them into one. You could also still fix it for this one because you locally can squash and git push --force but I don't think is worth it this time.

Regarding paring down to only one added field, should I stash my larger changes locally, or just comment out the others until we are ready to roll them in?

you can leave this pull request/branch here for now, my suggestion would be to just create a new branch from master and add manually whatever new value you pick and try to make a pull request, at least until you get a full workflow completed on how to add changes in here.

AdamRJonesHPD commented 3 years ago

Sounds good, thanks. I'll put some work into it today.