pablodz / pipewire_python

Python controller, player and recorder via pipewire's commands
https://pablodz.github.io/pipewire_python/html/
MIT License
22 stars 7 forks source link

Add Submodule for `pw-link` #15

Closed engineerjoe440 closed 1 year ago

engineerjoe440 commented 1 year ago

Related Issue: #14

Updates:

Additions:

pablodz commented 1 year ago

Also, please change the version to 0.2.2

https://github.com/pablodz/pipewire_python/blob/01a38f185735b90cce51dbf46f37c37b738a8422/pipewire_python/__init__.py#L70-L70

codecov[bot] commented 1 year ago

Codecov Report

Merging #15 (8e9afb0) into main (4af72ae) will decrease coverage by 7.36%. The diff coverage is 47.71%.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   65.62%   58.26%   -7.37%     
==========================================
  Files           4        5       +1     
  Lines         288      484     +196     
==========================================
+ Hits          189      282      +93     
- Misses         99      202     +103     
Impacted Files Coverage Δ
pipewire_python/controller.py 65.60% <ø> (ø)
pipewire_python/link.py 47.44% <47.44%> (ø)
pipewire_python/__init__.py 80.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

engineerjoe440 commented 1 year ago

Also, please change the version to 0.2.2

https://github.com/pablodz/pipewire_python/blob/01a38f185735b90cce51dbf46f37c37b738a8422/pipewire_python/__init__.py#L70-L70

Definitely! I wasn't thinking of that.

pablodz commented 1 year ago

@engineerjoe440 the PR is still as draft, tag me when it's ready please

engineerjoe440 commented 1 year ago

@engineerjoe440 the PR is still as draft, tag me when it's ready please

Sure, @pablodz ! I'll get my branch updated for authors.

There's still a point about PRs targeting a develop branch, did you want me to re-target this PR?

pablodz commented 1 year ago

I'ts ok to target main , I'll run some tests before releasing to pypi

engineerjoe440 commented 1 year ago

Thanks, @pablodz!

I can't quite make out what's erroring out in the build tests, so if there are things you would like me to address, just let me know! :smile:

Thank you!