search

pablogsal / black-pycharm

Pycharm plugin for https://github.com/ambv/black
32 stars 11 forks source link

Gradle #13

Open Iain-S opened 4 years ago

Iain-S commented 4 years ago

Hi @pablogsal

I have made some changes to address the first suggestion in Issue #11 . That is the later commit (a2e1cd2).

The earlier commits do two things:

  1. Switch to using Gradle for the build. When I originally opened the project with IDEA, it wasn't apparent how to make the plugin .zip from the code so I followed these instructions to make a Gradle-based project.
  2. Address warnings from CheckStyle and IDEA code analysis. I flip-flopped between 2-space and 4-space indentations and restored the 4-spaces in the last commit.

I think you should be able to cherry-pick commits if you don't want to switch to Gradle and only want the code formatting and line-length changes.

All the best

Iain

txomon commented 3 years ago

Hey! I have used your commits and refactored some stuff in https://github.com/txomon/black-pycharm/tree/feature/upgrade-and-gradle

Specifically, I'm dropping the .idea/ folder which shouldn't be part of the repo (it's coupling the development environment to one specific editor), and additionally I'm (I think) dropping the version compatibility constraint that doesn't let us use the plugin in the latest versions. black-pycharm-1.0.7.zip