search

pablojim / highcharts-ng

AngularJS directive for Highcharts
MIT License
1.73k stars 463 forks source link

DynamicYAxis #584

Closed fintrader closed 7 years ago

fintrader commented 7 years ago

-Allows monitoring of dynamic yAxis additions and subtractions -Created a helper function this.removeUnlinkedObjects to help separate out the code -Renamed variables in ensureIds to better represent the functions creating Ids for more than series

pablojim commented 7 years ago

@Yoshi9143 great work. I'll get around to merging it soon. The tasks I intend to do are:

I'll hopefully get to these at some point. But if you get there first then I'm happy to merge.

pablojim commented 7 years ago

@Yoshi9143 could you give me permissions to write to this fork? https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/

pablojim commented 7 years ago

closed as part of #595. Thanks @Yoshi9143 !

fintrader commented 7 years ago

Thank you! Sorry I am on vacation and now getting to some work time here so I wasnt able to give you fork permissions

Thank you so much! Rishi

On Sun, May 14, 2017 at 8:08 PM, Barry Fitzgerald notifications@github.com wrote:

Closed #584 https://github.com/pablojim/highcharts-ng/pull/584.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pablojim/highcharts-ng/pull/584#event-1081376540, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJxvVXK1Rucc-AOmuuZVLxLxxA8f7_Oks5r51E8gaJpZM4NDJyS .