search

pablojim / highcharts-ng

AngularJS directive for Highcharts
MIT License
1.73k stars 463 forks source link

Highcharts license issue #626

Closed ngehlert closed 6 years ago

ngehlert commented 6 years ago

This should fix the dependency issues for highcharts that are discussed in #624 and #623

ngehlert commented 6 years ago

hm i have no idea how the git rid of the commits from the previous pull request... i tried to follow this introduction https://help.github.com/articles/syncing-a-fork/ ... also this one https://gist.github.com/Chaser324/ce0505fbed06b947d962 but they are still there...

pablojim commented 6 years ago

For clarity it's best to start a new branch from an updated master. But no worries for now.

ngehlert commented 6 years ago

well i did started from an updated master. those commit log entries are in my master and i'm not able to get rid of them... don't know... i will keep looking, maybe i just did something wrong. Or worst case i delete the fork and re-fork it again 😆

ngehlert commented 6 years ago

@pablojim sorry to bother you again, any updates on when you have time to verify and accept this PR? and when the next version will be released? kind of waiting for it 😄

marcel-tov commented 6 years ago

+1

pablojim commented 6 years ago

@ngehlert merged. Unfortunately I'm not going to be near my laptop until first week in December to do the release.

ngehlert commented 6 years ago

@pablojim ok thanks for your response :) looking forward to first week in december then 😄

pablojim commented 6 years ago

@ngehlert released now!

ngehlert commented 6 years ago

@pablojim awesome stuff. thanks