Update en Nginx Ingress Controller

chanix95 commented 2 years ago

Hola Pelado, Primero que todo, gracias por tanto!

Intenté seguir el video y encontré un par de errores. Actualicé los manifiestos, me parece que había un par de cosas deprecadas.

Fix: builtin Secret type kubernetes.io/tls

Error trying to get the default server TLS secret nginx-ingress/default-server-secret: nginx-ingress/default-server-secret is invalid: TLS Secret must be of the type kubernetes.io/tls

Referencias: kubernetes docs, Ejemplo del repo Nginx Ingress Controller, Guia de instalación de NGINX Ingress Controller

Fix: IngressClass resource

Error when getting IngressClass nginx: ingressclasses.networking.k8s.io "nginx" not found

Referencias: kubernetes docs, Guia de instalación de NGINX Ingress Controller, Ejemplo del repo Nginx Ingress Controller

Resolves #182

gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | RSA Private Key | 203601986306bf1c91b0a4ad16f9b4020fae8385 | kubernetes/8/ingress/02-default-server-secret.yaml | [View secret](https://github.com/pablokbs/peladonerd/commit/203601986306bf1c91b0a4ad16f9b4020fae8385#diff-7ff4676210da5e59d410d7f4e9b3104dR9) |

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/specifics/base64_private_key_rsa#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

gmarcos87 commented 2 years ago

Gracias @chanix95 esto soluciona el problema. Y gracias @pablokbs por compartir todo esto.

pablokbs / peladonerd