pablomarle
commented
3 years ago Hello.
Can you provide your config file (without the smtp passwords).
Thanks, Pablo.
Open shammyx opened 3 years ago
pablomarle
commented
3 years ago Hello.
Can you provide your config file (without the smtp passwords).
Thanks, Pablo.
shammyx
commented
3 years ago Hi Pablo, thanks for your quick reply. My current config looks like
{
"socket": {
"address": "192.168.56.19",
"port": 3000
},
"sendmail": {
"server": "mail.lan",
"port": 25,
"is_secured": false,
"user": "none",
"password": "none",
"from": "networkmaps@my.domain"
}
}Cheers, Alex
pablomarle
commented
3 years ago Hello.
Can you try the option "use_client"? That should fix the issue. This option makes the browser to not use an absolute path when accessing resources from the server. Your config file would look like this:
{
"socket": {
"address": "192.168.56.19",
"port": 3000
},
"server": {
"use_client": true
},
"sendmail": {
"server": "mail.lan",
"port": 25,
"is_secured": false,
"user": "none",
"password": "none",
"from": "networkmaps@my.domain"
}
}This worked, thanks! Wouldn't it make sense to make this the default config and put this modified config as default in the docs? One could also add that info to the explanation of "use_client". I'd be happy to help with a pr but it looks like the docs are not in this repo?
This issue can then be closed.
shammyx
commented
3 years ago Oh, I just tried the reverse proxy (apache), this is still not working with "use_client", maybe related to the DNS/IP issue, not sure, should I open a new thread?
edit: More details... I set up an apache reverse proxy with following apache site config
<VirtualHost *:80>
ErrorLog ${APACHE_LOG_DIR}/error.log
CustomLog ${APACHE_LOG_DIR}/access.log combined
ProxyPass "/" "http://networkmaps.bsc:3000/"
ProxyPassReverse "/" "http://networkmaps.bsc:3000/"
</VirtualHost>If you need, I can post again more, like the ./server.js logs.
pablomarle
commented
2 years ago Sorry for the late reply. I have a similar setup but with NGINX and that is working fine.
I'll try to replicate the issue and let you know if I succeeded.
And yes, it makes sense to have this option as the default. I'll try to update the code :)
Levvy055
commented
2 years ago Using NGINX as SSL proxy emerges new problems.
WebSocket connection to 'wss://my.subdomain.pl/user' failed:
I have tried to fix it but nothing works:
"use_ssl_socket": false,
"use_ssl": true,
"socket": {
"address": "my.ip.address",
"port": 3090
},
"server": {
"hostname": "my.subdomain.pl",
"port": 443,
"use_client": true
},Without use_ssl the connection is x origin failed and without port 443 in server part - ERR_SSL_PROTOCOL_ERROR
pablomarle
commented
2 years ago Sorry for the late reply.
This is a working nginx sample configuration (I've removed parts that I don't think are strictly needed)
There are two endpoints in networkmaps that are websockets and need special handling in nginx: user and diagram. I suppose this is what is failing on your setup.
Let me know if this helps you in setting up your reverse proxy.
server {
listen 443 ssl;
listen [::]:443 ssl;
server_name app.networkmaps.org;
ssl_certificate ***************************;
ssl_certificate_key *************************;
add_header X-Frame-Options DENY;
add_header X-Content-Type-Options nosniff;
add_header X-XSS-Protection "1; mode=block";
location /diagram {
proxy_set_header Host $host;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header X-Forwarded-Proto $scheme;
proxy_pass http://localhost:3000/diagram;
proxy_http_version 1.1;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection "Upgrade";
}
location /user {
proxy_set_header Host $host;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header X-Forwarded-Proto $scheme;
proxy_pass http://localhost:3000/user;
proxy_http_version 1.1;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection "Upgrade";
}
location / {
proxy_set_header Host $host;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header X-Forwarded-Proto $scheme;
proxy_pass http://localhost:3000;
}
client_max_body_size 8M;
}Hey, thank you for this nginx configuration file, I'll try tomorrow and will let you know if it solves the problem!
shammyx
commented
2 years ago Thanks Pablo! With your config everything seems to run smoothly and my problems solved. I'll let this issue open in case Levvy has something to add. Feel free to close it. I think it could be valuable to link to this issue on your readme or to put a section about reverse proxy in your documentation. Maybe both. All the best and merry Christmas :)
edit: I was not interested in using https so far, but trying it out shows there still seems to be an issue with that. I just used the posted config without the ssl parts and listening on port 80. When I switch to TLS, I just get a blank screen in the browser. The connection is secured, so certificates are working. I can provide logs and try to help figure this thing out, if there's a need. Levvy or Pablo, what do you think?
Describe the bug When I call networkmaps with its IP it mostly works well but as soon as I use the DNS name, I cannot load network maps correctly. There are popping up some errors in the UI with something closed and "Error loading definition file for shape group 5. Connection error." and sometimes also other groups, e.g., "Error loading definition file for shape group 2. Connection error." One cannot see anything in a new diagram, in an existing diagram one sees only some cubes instead of the correct devices.
To Reproduce Steps to reproduce the behavior:
Expected behavior When I call the server via its DNS name instead of its IP it should work exactly the same way as when IP is used.
Desktop (please complete the following information):
Additional context networkmaps is running on a dedicated testing VM on proxmox, there's nothing else on it. VM is debian 11 bullseye with node v12.22.5. Tested on other machines as well, issue seems to be server-related. I also tried using an apache reverse proxy without any improvements. I also tried to provide the dns name instead of IP in the config "address" field to no avail. The live log reads as follows:
Please let me know if you need further details.