pablomatgar / Japanese-Sign-Language-Interpreter

Mobile application developed using Vue.js, Monaca, Framework7, Cordova and Teachable Machine, which recognises gestures from the Japanese Sign Language and converts them to Japanese text, with the possibility of translating them into English or Spanish.
MIT License
2 stars 3 forks source link

`isAndroid` and `isIos` should be outside of `export default { ... }`. #15

Closed asial-matagawa closed 2 years ago

asial-matagawa commented 2 years ago

@pablomatgar Unlike isMobile, the two functions isAndroid and isIos are not using the component's methods and reactive variables and not used in <template>...</template>. In this case, isAndroid and isIos should be moved to the isAndroid and isIos to decrease the complexity of setup function. https://github.com/pablomatgar/Japanese-Sign-Language-Interpreter/blob/dfb007f35bdb76c0e841cb94e09fdcd115badbf3/src/pages/home.vue#L105-L115