pabloromeo / clusterplex

ClusterPlex is an extended version of Plex, which supports distributed Workers across a cluster to handle transcoding requests.
MIT License
470 stars 36 forks source link

Issue with credit detection #231

Closed flopon closed 8 months ago

flopon commented 1 year ago

End credit detection is offered by plex server since 1.31.0.

There is definitely a lot to fix on PLEX team side (forum is full of bug reports), but I think there is also an issue specifically when using clusterplex, as I have been able to use it when disactivating the docker mod, but was not able to use it whit docker mod enabled (log showing a "Job failed: Decryption failed" error in this case.

Is someone been able to use PLEX credit detection while using clusterplex ?

pabloromeo commented 1 year ago

Yeah, I think you may be right. Just tested it and I've found an issue related to credit detection, which causes the worker to fail. However, I'm not entirely sure the "Decryption failed" error is caused by us, that seems to happen either way, from what I saw on the forum issues. I'll let you know once I have a fix ready so you can try it out.

pabloromeo commented 1 year ago

Release v1.4.5 https://github.com/pabloromeo/clusterplex/releases/tag/v1.4.5 should fix the Credits Detection issue

flopon commented 1 year ago

Nop, still having the same issue, with a [Req#3d5/CreditsDetectionManager] Job failed: Decryption failed error, not present in the log if I remove the docker mod.

The file is readen on local server, but the credit detection fail. Seems to be trickier than just on ly having to read the file locally !

I will try to do some more analysis the next week.

pabloromeo commented 1 year ago

That's odd! Yeah, ultimately what I was seeing is that Plex's Credits Detection was also calling the transcoder (which we overwrite), however, for Credits Detection they don't respect their own configured transcode path, and instead use /tmp directly. Using /tmp fails with ClusterPlex since it's not shared across workers. Ultimately what I did was bypass any sort of remote transcoding for Credit Detection, just calling Plex's local transcoder directly.

Regarding the error message, yes, I see that too in the logs, but given that in the forum there are tons of messages about that error and a reply from a Plex developer addressing it, I didn't pay much attention, especially since credit detection started working after the 1.4.5 fix.

One thing that is quite problematic with the Credits Detection stuff, is that it seems Plex is collecting stdout but not forwarding it to the logs, which makes it very difficult to debug, since there' absolutely nothing in the logs or console when Plex Media Scanner calls the transcoder.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 14 days since being marked as stale.

flopon commented 1 year ago

Haven't a lot of time to investigate since my original post, but FYI, still thinking there is still something we can fix in transcoder.js.

If I just replace the modified Plex Transcoder with the original one, credit detection is perfectly working (and of course distributed transcoding did not ^^)

Will try to investigate further. And yes, not having any log from Plex Media Scanner is a pain !

PS : I'm on the Dockermod Version, in a LXC unprivileged CT, on Proxmox 8.0

github-actions[bot] commented 12 months ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 11 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] commented 10 months ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 10 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] commented 8 months ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 8 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.