pablovegan / Economic-Planning

Receding horizon planning as in Loke and Zachariah's https://github.com/lokehagberg/rhp
https://pablovegan.github.io/Economic-Planning/
GNU General Public License v3.0
4 stars 0 forks source link

Graphs in documentation differ from the ones generated locally #1

Open tales-hein opened 1 month ago

tales-hein commented 1 month ago

Hello! First time running the code provided in the repo. I installed all the external modules used and copied the cybersyn module directory inside the Spain examples directory, and run the scripts in the .ipynb file. But I noticed that this created some graphs that are different from the ones produced by the same scripts in the documentation. I will share prints of the graphs that changed, the rest look exactly the same as I saw them in the docs.

Sourced by the documentation: image

Produced locally: image

Sourced by the documentation: image

Produced locally: image

pablovegan commented 1 month ago

Hi! Thanks for trying the repo! I did get the same plots locally as in the docs... Anyway, I realized that the Swedish example was not updated to the new code. You can now try if both Spain and Sweden's notebooks agree with the docs...

tales-hein commented 1 month ago

As your local execution works as expected I will try some more debugging to better understand what could be happening on my side. Thank you for the response! I will try to reach out with news as early as possible so that the issue can be closed.