search

pablrod / p5-Chart-Plotly

Generate html/javascript charts with perl data using javascript library Plotly.js
MIT License
9 stars 4 forks source link

support Alien::Plotly::Orca #18

Closed iynehz closed 5 years ago

iynehz commented 5 years ago

Today I released Alien::Plotly::Orca https://metacpan.org/pod/Alien::Plotly::Orca. And this is basic changes to support Alien::Plotly::Orca. As orca may not work on some OS plaltforms or in some condtions, I don't want Alien::Plotly::Orca a runtime-"requires" of Chart::Plotly, instead we can just suggest user install it from CPAN in our error message.

I will still get some time later this week to look at the local plotly.js thing, and after that I will probably get back to get orca() to support local plotly.js.

iynehz commented 5 years ago

Oh I was not aware that the local plotlyjs thing has already been merged and released: it's not in changelog on MetaCPAN. Thanks for that work. Now I just added a second commit in this PR to get orca command to use the local plotlyjs. (Actually it seems that without the local plotljs setup orca would visit plotly's cdn only at the first time and cache it under user home, but IMHO it's still somewhat better to completely remove the need of network connection here.)

pablrod commented 5 years ago

Looks good to me!!

Thank you for this work!!

I'm going to add to the ChangeLog the support for local plotly.js!