Compiler warnings for GCC (Eigen)

coppolachan commented 7 years ago

GCC throws a lot of the following harmless warnings, coming from the Eigen lib

                 from /home/dc-coss2/Codes/RMHMC/Stealth-Grid/include/Grid/Eigen/Dense:1,
                 from /home/dc-coss2/Codes/RMHMC/Stealth-Grid/include/Grid/lattice/Lattice_reduction.h:25,
                 from /home/dc-coss2/Codes/RMHMC/Stealth-Grid/include/Grid/lattice/Lattice_base.h:339,
                 from /home/dc-coss2/Codes/RMHMC/Stealth-Grid/include/Grid/lattice/Lattice.h:31,
                 from /home/dc-coss2/Codes/RMHMC/Stealth-Grid/include/Grid/GridCore.h:54,
                 from /home/dc-coss2/Codes/RMHMC/Stealth-Grid/include/Grid/Grid.h:41,
                 from ../../Stealth-Grid/lib/qcd/spin/Gamma.cc:3:
/home/dc-coss2/Codes/RMHMC/Stealth-Grid/include/Grid/Eigen/src/Core/Functors.h:977:28: warning: ‘template<class _Operation> class std::binder1st’ is deprecated [-Wdeprecated-declarations]
 struct functor_traits<std::binder1st<T> >

should we suppress them or look for a newer version of the Eigen that solves this?

paboyle commented 7 years ago

Updating Eigen would be best, clearly. As you know I hate warning suppression and would rather just have legal code, even though this is strictly a deprecated warning and GCC is being a bit naughty (in the sense that verbose warning on constructs still supported but planned for deprecation is a pain in the ass pedant thing to do).

aportelli commented 7 years ago

I agree, especially that Eigen has been going through several versions since. New versions does support AVX512. In principle just the URL in the Eigen script should be changed.

On 9 May 2017, at 12:03, Peter Boyle notifications@github.com wrote:

Updating Eigen would be best, clearly. As you know I hate warning suppression and would rather just have legal code, even though this is strictly a deprecated warning and GCC is being a bit naughty (in the sense that verbose warning on constructs still supported but planned for deprecation is a pain in the ass pedant thing to do).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

paboyle commented 7 years ago

updated to 3.3.3

coppolachan commented 7 years ago

is the problem solved with the update?

paboyle commented 7 years ago

Was on my laptop; I'm waiting for travis to verify and close.

paboyle commented 7 years ago

Compiled clean closing.

paboyle / Grid

Compiler warnings for GCC (Eigen) #104