updating Eigen to 3.4.0

paboyle / Grid

Data parallel C++ mathematical object library

GNU General Public License v2.0

155 stars 111 forks source link

updating Eigen to 3.4.0 #451

Closed aportelli closed 9 months ago

aportelli commented 9 months ago

This PR update the deployed version of Eigen in the bootstrap step to 3.4.0. This was motivated by

compatibility when including Grid in other software using more recent versions of Eigen
remove the necessity of patching the tensor headers for non-portable includes
significantly lower level of warnings with recent compilers
general maintenance (3.3.5 was 5 years old)

I am waiting for CI confirmation and will followup here

paboyle commented 9 months ago

I'm ok with updating Eigen -- might give us the ability to run Eigen on GPU, which was flaky and NVCC version dependent for a long period.

aportelli commented 9 months ago

Hi @paboyle, thanks. I waited for CI checks, now successful, which took a while because of maintenance. I also used this branch internally and did not encounter it. So I think it is safe to merge at your discretion.

paboyle commented 9 months ago

Thanks. Will be nice to have another crack at Eigen on the GPU.