search

pabsttheater / pabstetix

Issue Tracking for pabsttheater.org
0 stars 0 forks source link

You Might Like widget doesn't respect CTA Labels #19

Closed sarandi closed 6 years ago

sarandi commented 6 years ago

When updating an event's CTA labels, the You Might Like widget system seems to only use defaults. This is related to closed issue #10

Use Case and Testing:

  1. As a test, I change the Canceled CTA Label on our Rahsaan Patterson show to read "Cancelled" instead of the default "Canceled"
  2. I check the event page and calendar page, both look accurate: image

image

  1. I find a genre-related show (Sir The Baptist) (should display Rahsaan Patterson in the You Might Like widget)

  2. The CTA text in the YML widget still reads "Canceled" when it should read "Cancelled". image

  3. I clear the cache

  4. I reload the event/widget again, but flushing the cache didn't fix the problem

  5. I uncheck the "canceled" checkbox, update the event, check the canceled checkbox again and update the event

  6. I reload the event/widget again, no change

  7. I clear the cache

  8. I reload the event/widget again, no change

sarandi commented 6 years ago

This also seems related to issues #10 and #14 - in fact, the sidebar view templates still don't seem to be using the same code. When one of them are updated, they should all be updated to reflect that change.

sarandi commented 6 years ago

I just re-tested this on staging and it's not working:

Changed the text to Sold Outt image

Reads Sold Out instead of Sold Outt image

sarandi commented 6 years ago

As of today this fix has not been deployed to Production. Seems to be fixed on staging.

sarandi commented 6 years ago

Documentation of the fix, screenshot taken today on staging: image

No incognito, cache flush, hard refresh, or timing delay necessary here - I simply edited the CTA field and it displayed in a non-logged-in browser.

sarandi commented 6 years ago

Good.