search

pac-dev / protoplug

Create audio plugins on-the-fly with LuaJIT.
Other
278 stars 36 forks source link

Push controller support #11

Closed JTriggerFish closed 9 years ago

JTriggerFish commented 9 years ago

Hi Pac,

I'm working on adding support for the Push midi controller, as you can see in my fork. I did a quick proof of concept which works very well and I'm now working on making a full blown integrated API. I would really like to merge this back to the official repository at some point; would you mind taking a look at what I've done so far to see if you agree with the direction, if not it would be better for me to make some changes now than later.

Thank you ! JT

pac-dev commented 9 years ago

Hi JT, I haven't had the time to test it but from a quick look I think it's fine. Try rebuilding the documentation, all that's needed is standalone Lua and ldoc, then run something like this:

cd /path/to/ProtoplugFiles/doc/src
lua /path/to/ldoc/ldoc.lua -d ../ .

ldoc generates the docs mostly from comments (more details on this page).

No need to make everything fit into the generated documentation. For example the code in the controllers folder may not need to be in the docs like the rest, I'm not sure. But still there should be something that tells us how to use it.

And the new comments in midi.lua generate documentation incorrectly. I'd fix it myself but probably not this week!

JTriggerFish commented 9 years ago

Great, thanks for having a look and for the pointers on the documentation ! I completely agree that the documentation of the new stuff needs to be fixed, my plan was to finish writing and testing and then sort it out. I probably need a few more weeks for that depending of how much spare time I get, once it's all ready I will send you a pull request.

Thanks !