search

pacbard / gChartPhp

Apache License 2.0
88 stars 45 forks source link

Installation via composer and PSR-0 compliance #6

Closed aimfeld closed 12 years ago

aimfeld commented 12 years ago

Dear pacbard,

First of all, thanks for providing this library!

I made your gChartPhp library PSR-0 autoloading compliant by moving the classes in the gchart namespace to a directory named gchart (see https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-0.md).

I additionally added a composer.json file to make the library installable using packagist/composer (see http://packagist.org/packages/gChartPhp/gChartPhp). This is great for automatic deployment using phing (see http://www.phing.info/trac/). Many PHP libraries support PSR-0 autoloading via composer, I hope you consider pulling my request.

Furthermore, I fixed the examples in view.html, they were broken.

Cheers, Adrian

pacbard commented 12 years ago

Thank you Adrian for the addition! Unluckily, I am not able to actively develop PhpGChart anymore, so improvements are always very welcome!

aimfeld commented 12 years ago

Thanks for considering my pull request pull-worthy :).

I just saw that the google image charts have been deprecated: https://google-developers.appspot.com/chart/image/

So I won't put to much effort in google image charts and implement google interactive charts instead: https://google-developers.appspot.com/chart/