pace-neutrons / Euphonic

Euphonic is a Python package for efficient simulation of phonon bandstructures, density of states and inelastic neutron scattering intensities from force constants.
GNU General Public License v3.0
29 stars 11 forks source link

Consider making Crystal.cell_volume() a @property #289

Open ajjackson opened 1 year ago

ajjackson commented 1 year ago

Suggested by @oerc0122 in #288 review

Things would look a little cleaner if this was accessed as a property, and it would be nice if the result was cached.

It's a breaking change though, so should be deferred until v2 if it happens at all.