pace-neutrons / Horace

Horace is a suite of programs for the visualization and analysis of large datasets from time-of-flight neutron inelastic scattering spectrometers.
https://pace-neutrons.github.io/Horace/stable/
GNU General Public License v3.0
7 stars 4 forks source link

broken accumulate_sqw code #1629

Closed abuts closed 4 months ago

abuts commented 5 months ago

It was identified while working with ticket #1627 that code, responsible for accumulating additional sqw files into existing sqw file is broken. Currently it has been removed as I do not belive it used anywhere and certainly it is not tested.

This ticket should address the following issues:

1) is accumulate code still necessary (if it is, it will be inheritably slow) 2) Should it be implemented as possibility to add more runs to existing sqw file? 3) if not, some job should be performed with gen_sqw to regularize and rethink its input parameters parsing and the internal logic of the code itself.

abuts commented 4 months ago

fixed throug Re #1633