pace-neutrons / Horace

Horace is a suite of programs for the visualization and analysis of large datasets from time-of-flight neutron inelastic scattering spectrometers.
https://pace-neutrons.github.io/Horace/stable/
GNU General Public License v3.0
7 stars 4 forks source link

Curvilinear proj verification #1638

Closed abuts closed 4 months ago

abuts commented 4 months ago

This PR partially deals with Re #954 and verifies some components of spherical/cylindrical projection operations. It is not total validation but the changes here are big enough to have PR and close this particular ticket. Other validation ticket will follow.

The PR added number of tests for cylindrical cuts, some have physical meaning so it is obvious that they are correct. Some reproduce the results produced by previous implementation for cylindrical cuts.

In addition, this ticket deals with validation of target ranges identification algorithm. Code have been changed and improved and number of unit tests were written to validate and support its operations. It still not ideal and can be done better, but current implementation is good enough.

abuts commented 4 months ago

fixes Re #954