search

pace-neutrons / Horace

Horace is a suite of programs for the visualization and analysis of large datasets from time-of-flight neutron inelastic scattering spectrometers.
https://pace-neutrons.github.io/Horace/stable/
GNU General Public License v3.0
7 stars 4 forks source link

Add doc describing how to convert Horace 3 -> 4 #1642

Closed oerc0122 closed 3 months ago

oerc0122 commented 4 months ago

Fixes #1632

abuts commented 4 months ago

One more thing -- simulation and fitting -- where is the description of the convertsion script and does it work?

IDAAAS->/HoraceExampleScripts/SimulationAndFitting.m This contains fit_func --> this probably does not work even with Horace-3

you had script which should convert it into modern format and this script should be modified. (and sample on IDAAAS should be changed -- I've applied for access -- do not have it)

oerc0122 commented 4 months ago

One more thing -- simulation and fitting -- where is the description of the convertsion script and does it work?

IDAAAS->/HoraceExampleScripts/SimulationAndFitting.m This contains fit_func --> this probably does not work even with Horace-3

you had script which should convert it into modern format and this script should be modified. (and sample on IDAAAS should be changed -- I've applied for access -- do not have it)

The section Multifit covers this.

Also, I don't understand, what does a script on IDAaaS have to do with this documentation?

abuts commented 4 months ago

IDAAAS script contains examples of the Horace usage and it is Horace-3 usage. 1) It has to be converted to Horace-4, I am doing that. 2) You are describing how it has to be converted, are not you? So this is relation

oerc0122 commented 4 months ago

IDAAAS script contains examples of the Horace usage and it is Horace-3 usage.

  1. It has to be converted to Horace-4, I am doing that.
  2. You are describing how it has to be converted, are not you? So this is relation

So your comment doesn't want anything to change in the documentation you are just notifying me that you are changing a script on IDAaaS? I guess that could be useful if you find anything isn't covered here, but I don't think it should block this PR.

abuts commented 4 months ago

I am saying that the changes to alignment between Horace-3 and Horace-4 are very small and I have today modified the script on IDAAAS to reflect these chagnes.

There are substantial internal changes to alignment, but from user point of view, it is just change to output of one alignment function and changes to the meaning of the parameters of another alignment function.

May be worth telling that operation on aligned object realign result. (e.g. result of the cut of realigned data is properly aligned cut)