Closed cmarooney-stfc closed 3 months ago
I think it is only the beginning of the changes as you hasing serializable and this is unnecessary as fields for hash are the same.
Hash should be build from values of the fields and be stored with object (hashable
)
Re Alex' comment
GetMD5.c only kept until .cpp version known to work - now removed. mex file now added but let's remove them all systematically at some point engine initialization now made conditional on use_mex value In an ideal world Matlab would have class variables and we would not need to use persistent here. However, if we are going to separate hashing from unique_objects_container, as previously requested, then I prefer to have it in a class from the start as it provides growing room if this needs further modification e.g. for uses outside the unique containers.