Fix issue with 4.0.0 spaghetti plot

pace-neutrons / Horace

Horace is a suite of programs for the visualization and analysis of large datasets from time-of-flight neutron inelastic scattering spectrometers.

https://pace-neutrons.github.io/Horace/stable/

GNU General Public License v3.0

7 stars 4 forks source link

Fix issue with 4.0.0 spaghetti plot #1711

Closed oerc0122 closed 3 months ago

oerc0122 commented 3 months ago

Issue was with which space vectors were computed in.

Fixed and simplified spaghetti plot using Horace 4 features.
One notable difference is that qwidth now specifies a full-width rather than a half-width confirmed by Duc to be the original intent, however, this means that spaghetti_plot qwidths in new Horace are half those of Horace 4. N.B. Can back this change out.

Fixes #1710 Fixes #1709

oerc0122 commented 3 months ago

it would be nice to know what actually fixes the problem. a lot of renaming obscures the activ changes

What fixes the problem is passing arguments in the correct basis. Something I had failed to understand is that type in a proj does not define the units of the input of u and v (which are always in reciprocal lattice units), but only of the binning arguments as fractions of u and v post-rescaling according to type.

oerc0122 commented 3 months ago

As I understand, the selected implementation of the spaghetty plot follows the option 1

I think this should be included in description (e.g.: "Note: the cuts performed between each reciprocal lattice points are ovelapped at the bin centers". If this is option 2 -- still needs to be specified Something like this.

This suggestion is addressed in issue #1415 however, a brief discussion with Adroja suggests that the behaviour they want/expect is what you have in diagram 1.

At some point in the future we may implement #1415 as a boolean option (following this refactor it is now very simple to do).