search

pace-neutrons / Horace

Horace is a suite of programs for the visualization and analysis of large datasets from time-of-flight neutron inelastic scattering spectrometers.
https://pace-neutrons.github.io/Horace/stable/
GNU General Public License v3.0
8 stars 5 forks source link

Parallel multifit fails for some set of input parameters #1724

Open abuts opened 3 months ago

abuts commented 3 months ago

The ticket Re #1721 fixes crystal_alignment for case when parallel_multifit is enabled by disabling parallel mutlifit option in crystal alignment.

This is probably fine for crystal_alignment as it does not need to run in parallel. But similar issue may occur for different multifit user cases so splitting procedure in multifit should be smarter to identify such parameters and either do correct split or (better) be smart enough to identify that parallel multifit in this case is unnecessary and multifit should not run in parallel.

Unit test written and disabled in Re #1721: Horace\_test\test_multifit_herbert\test_multifit_1.m, row 362 should be fixed.