Migrate DnD API to new classes

pace-neutrons / Horace

Horace is a suite of programs for the visualization and analysis of large datasets from time-of-flight neutron inelastic scattering spectrometers.

https://pace-neutrons.github.io/Horace/stable/

GNU General Public License v3.0

8 stars 5 forks source link

Migrate DnD API to new classes #507

Closed nickbattam-tessella closed 3 years ago

nickbattam-tessella commented 3 years ago

Migrate the full (old) DnD APIs to the new DnD classes, excluding the 'fit' functions.

Follows #490

Outcome:

[x] All DnD methods implemented on new class (D2D)
[ ] All DnD methods implemented on new class (D0D, D1D, D3D and D4D)
[ ] Simple tests implemented to verify all methods can be executed

nickbattam-tessella commented 3 years ago

This ticket includes the removal of identical duplication of SQW and DnD implementations of functions, moving the code to the SQWDnDBase class where possible. This should allow the removal of the current implementations in DnD which cast from DnD to SQW, execute the SQW function and cast the result back to the appropriate DnD class

cmarooney-stfc commented 3 years ago

First checkbox should be DnD

cmarooney-stfc commented 3 years ago

Also not sure your checkboxes correspond to the first comment after the description