This involved a bit of refactoring of find_version to make it easier to follow, I've tried to keep the behaviour the same (e.g. setting the arch and ver attributes), even though I'm not sure we actually need to set those, any further changes to behaviour can come later. Just a few more things:
Previous behaviour looked only in directories named 'runtime', except when searching the second directory level it searched directories with any name, was this intended or an oversight? Can we guarantee the lib file is always in a runtime directory?
The second directory level was searched in reverse alphabetical order, I'm guessing this was just an optimisation rather than anything else? I think glob should be faster than walking through each directory one-by-one so this should be ok.
Haven't tested on Linux yet, waiting for this PR to create a wheel...
Addresses #19
This involved a bit of refactoring of
find_version
to make it easier to follow, I've tried to keep the behaviour the same (e.g. setting thearch
andver
attributes), even though I'm not sure we actually need to set those, any further changes to behaviour can come later. Just a few more things:'runtime'
, except when searching the second directory level it searched directories with any name, was this intended or an oversight? Can we guarantee the lib file is always in aruntime
directory?