pace-neutrons / pace-python

Python module of the PACE inelastic neutron data analysis suite of programs.
GNU General Public License v3.0
3 stars 4 forks source link

Updates to CI build-test-release pipeline #33

Closed a-larkins99 closed 7 months ago

a-larkins99 commented 9 months ago

Jenkinsfile changes:

Github actions workflow changes:

Misc file changes:

Notes:

a-larkins99 commented 9 months ago

@mducle following the changes to fix the pace_neutrons command, the CI fails with the following error:

error in pace_neutrons setup command: "values of 'package_data' dict" must be a list of strings (got 'MCR_license.txt')

mducle commented 9 months ago

@a-larkins99

@mducle following the changes to fix the pace_neutrons command, the CI fails with the following error:

error in pace_neutrons setup command: "values of 'package_data' dict" must be a list of strings (got 'MCR_license.txt')

Ooops... sorry it was because the MCR_license.txt file was not being copied into the wheel... I didn't check the building of the wheel sorry. Could you change that line to:

    package_data={'pace_neutrons':CTFFILES, 'pace_neutrons':['MCR_license.txt']},

(e.g. make it a 1-element list).

a-larkins99 commented 7 months ago

I think all the required changes on this one are done now, unless you'd like the env bit changed to printenv?