search

paceaux / selector-finder

Find a CSS selector on a public site
MIT License
23 stars 3 forks source link

changes spacing of icons and adds info for element details #31

Closed paceaux closed 1 year ago

paceaux commented 1 year ago

Adds a new dependency for making fancy boxes Adds actual icons in the cli instead of whatever that was before. Makes the final result a tad more colorful

paceaux commented 1 year ago

logger was updated, but doesn't have enough jsdoced stuff. come on man.

paceaux commented 1 year ago

Yeah most of the tests are failing. All of the tests that rely on anything where logger is injected will have a problem.

paceaux commented 1 year ago

Most of the tests are passing again. They were failing because of the import '#whatever' syntax that was in chalk. This was a known issue in Jest By updating Jest, most unit tests pass.

Only test suite failing to run is selector-finder.puppeteer.test.js:

 The error below may be caused by using the wrong test environment, see https://jestjs.io/docs/configuration#testenvironment-string.
    Consider using the "jsdom" test environment.

    ReferenceError: navigator is not defined

      at node_modules/boxen/node_modules/chalk/source/vendor/supports-color/browser.js:4:2
      at node_modules/boxen/node_modules/chalk/source/vendor/supports-color/browser.js:16:3
paceaux commented 1 year ago

Finally got all tests passing with correctly importing the proper environment and then doing proper setup.

Let's merge it!