paceholder / nodeeditor

Qt Node Editor. Dataflow programming framework
BSD 3-Clause "New" or "Revised" License
2.94k stars 796 forks source link

[Fix] missing binary to install #306

Closed SaulBerrenson closed 2 years ago

SaulBerrenson commented 2 years ago

Hi, thanks for this project. I spent two evenings having fun with it. I found missing shared libs at install folder.

Looks below:

Config target before:

#----------------------------------------------------------------
# Generated CMake target import file for configuration "Debug".
#----------------------------------------------------------------

# Commands may need to know the format version.
set(CMAKE_IMPORT_FILE_VERSION 1)

# Import target "NodeEditor::nodes" for configuration "Debug"
set_property(TARGET NodeEditor::nodes APPEND PROPERTY IMPORTED_CONFIGURATIONS DEBUG)
set_target_properties(NodeEditor::nodes PROPERTIES
  IMPORTED_IMPLIB_DEBUG "${_IMPORT_PREFIX}/lib/nodes.lib"
  )

list(APPEND _IMPORT_CHECK_TARGETS NodeEditor::nodes )
list(APPEND _IMPORT_CHECK_FILES_FOR_NodeEditor::nodes "${_IMPORT_PREFIX}/lib/nodes.lib" )

# Commands beyond this point should not need to know the version.
set(CMAKE_IMPORT_FILE_VERSION)

After fix

#----------------------------------------------------------------
# Generated CMake target import file for configuration "Debug".
#----------------------------------------------------------------

# Commands may need to know the format version.
set(CMAKE_IMPORT_FILE_VERSION 1)

# Import target "NodeEditor::nodes" for configuration "Debug"
set_property(TARGET NodeEditor::nodes APPEND PROPERTY IMPORTED_CONFIGURATIONS DEBUG)
set_target_properties(NodeEditor::nodes PROPERTIES
  IMPORTED_IMPLIB_DEBUG "${_IMPORT_PREFIX}/lib/nodes.lib"
  IMPORTED_LOCATION_DEBUG "${_IMPORT_PREFIX}/bin/nodes.dll"
  )

list(APPEND _IMPORT_CHECK_TARGETS NodeEditor::nodes )
list(APPEND _IMPORT_CHECK_FILES_FOR_NodeEditor::nodes "${_IMPORT_PREFIX}/lib/nodes.lib" "${_IMPORT_PREFIX}/bin/nodes.dll" )

# Commands beyond this point should not need to know the version.
set(CMAKE_IMPORT_FILE_VERSION)

Install before: explorer_P5HoLloevz

Install after: explorer_4f7SgwkOZm

paceholder commented 2 years ago

Hi,

thanks for the pull request.

Do you think the dll libraries should be located in the bin directory? Because, for example, on Linux it is usually bin for executables and lib for shared libraries.

Thanks

Dmitry

paceholder commented 2 years ago

It might be that CMake sorts it out automatically depending on the current platform