search

paceholder / nodeeditor

Qt Node Editor. Dataflow programming framework
BSD 3-Clause "New" or "Revised" License
2.94k stars 796 forks source link

find_package() macro creates incompatibilities and should not be used #328

Closed Ivansstyle closed 1 year ago

Ivansstyle commented 1 year ago

from: nodeeditor/external/CMakeLists.txt

macro(find_package pkg)
  if(NOT TARGET "${pkg}")
    _find_package(${ARGV})
  endif()
endmacro()

Using redefinition of find_package() causes errors and incompatibilities with many libraries (OpenEXR, anything installed with vcpkg). Plese consider redefining to a different macro and updating dependant CMakeLists. Example: 

macro(_nodeeditor_find_package pkg)
  if(NOT TARGET "${pkg}")
    _find_package(${ARGV})
  endif()
endmacro()
paceholder commented 1 year ago

Please, see the pull request https://github.com/paceholder/nodeeditor/pull/329 Could you check if it works now?

paceholder commented 1 year ago

I hope it was fixed in master. Let me know if something does not work.