bug: `QJsonValueConstRef` in UndoCommands.cpp

[zmoth]

UndoCommands.cpp insertSerializedItems 77 and 90

77 for (QJsonValueConstRef node : nodesJsonArray)
...
90 for (QJsonValueConstRef connection : connJsonArray)
...

in this commit https://github.com/paceholder/nodeeditor/commit/4767ddb416f7a192991d53d63cbadb17ceb5716e

Hi @paceholder , Compilation does not pass, please fix as soon as possible.

I did not find a description of the class QJsonValueConstRef in the qt documentation.

[paceholder]

Sorry for that. It must be something from Qt6 which I have on my computer. Will fix immediately

[paceholder]

The type name is mentioned here but is not documented properly yet

https://doc-snapshots.qt.io/qt6-dev/qjsonobject-const-iterator.html#value

[zmoth]

Sorry for that. It must be something from Qt6 which I have on my computer. Will fix immediately

\error C2065: “QJsonValueConstRef”: Undeclared identifiers

my qt version is 6.2.1

You can use either auto or QJsonValueRef

[zmoth]

Why is QJsonValueRef displayed when I use auto auto-completion, is this different from QJsonValue?

[paceholder]

I think QJsonValueRef wraps both types QJsonValue and QJsonObject. You can write into object without explicit casting. I personally find all this classes a bit confusing. But the bug must be solved now

[paceholder]

QJsonValueRef is a helper class for QJsonArray and QJsonObject. When you get an object of type QJsonValueRef, you can use it as if it were a reference to a QJsonValue. If you assign to it, the assignment will apply to the element in the QJsonArray or QJsonObject from which you got the reference.

[zmoth]

Thank you for your explanation