search

paceholder / nodeeditor

Qt Node Editor. Dataflow programming framework
BSD 3-Clause "New" or "Revised" License
2.92k stars 795 forks source link

Simplifying cmake #354

Closed zmoth closed 1 year ago

zmoth commented 1 year ago

Every time I add or delete a file I forget to change cmake, change it to this and there will be no problem.

paceholder commented 1 year ago

The explicit listing of files has been done on purpose https://github.com/paceholder/nodeeditor/pull/142

Besides, your proposed changes with the variable ${QT_VERSION_MAJOR} do not work for some reason. I do not know whether it depends on cmake, OS or Qt version. In my case (Qt 6.4, MacOS, cmake 3.25) the variable remains empty after finding the Qt libs.

zmoth commented 1 year ago

Thank you for your reply

zmoth commented 1 year ago

But there is macos qt5.15.2 in the github ci and the compilation passes

paceholder commented 1 year ago

You are right, let me pull you branch to my computer and see what exactly happens

paceholder commented 1 year ago

Opps looks like you removed your branch completely

zmoth commented 1 year ago

Opps looks like you removed your branch completely

i restore it

zmoth commented 1 year ago

Hi @paceholder , One more thing that needs to be fixed , Now in cmake you use FATAL_ERRROR with the extra letter R

paceholder commented 1 year ago

Sorry for closing this PR immediately, I see that your changes work now. Dunno what was wrong with my attempts before.

Please have a look: https://github.com/paceholder/nodeeditor/pull/355 I took all your proposed changes, move an MSVC flag and kept the whole list of files