Small graphical bug with connections that are ascending

paceholder / nodeeditor

Qt Node Editor. Dataflow programming framework

BSD 3-Clause "New" or "Revised" License

3.05k stars 820 forks source link

Small graphical bug with connections that are ascending #78

Closed russelltg closed 7 years ago

russelltg commented 7 years ago

It seems when connections are ascending (like the car is going up a hill in a side-scroller) the top of the right side of the connection line starts to get cut off:

connbug

LandonJerre commented 7 years ago

Both ends are affected, if you look at your example, the line that comes out of the multiply node has a clipped bottom too. I ran into this too when I tried to reimplement connection drawing to use Catmull Rom splines instead of cubic Beziers, it looked like ConnectionGeometry::boundingRect sometimes gave back a slightly smaller rect than necessary. I've never got around fixing this, and eventually dropped the whole spline swapping thing.

russelltg commented 7 years ago

Good point, never noticed that!

paceholder commented 7 years ago

Should be fixed now.