pacemaker82 / PredBat-Table-Card

A custom Predbat table card that allows flexible column management and styling
7 stars 1 forks source link

Force discharge unreadable in dark mode #26

Closed gcoan closed 2 months ago

gcoan commented 2 months ago

White text on yellow background

image

pacemaker82 commented 2 months ago

should now be fixed in https://github.com/pacemaker82/PredBat-Table-Card/releases/tag/v1.5.3.5

Screenshot 2024-05-08 at 11 13 41
gcoan commented 2 months ago

thanks I'll have a look tonight

BTW it might be worth expanding the Predbat table card documentation to explain what the table card status descriptions mean as there's been at least one bit of confusion of discharge when idle vs planned discharge

https://github.com/springfall2008/batpred/issues/1057

gcoan commented 2 months ago

Agreed, discharge now readable

But.... should Charge in the split slot be coloured green as it is in the full slot?

image

Just noticed the split slot charge is also the (white) background colour in light mode image

pacemaker82 commented 2 months ago

should Charge in the split slot be coloured green as it is in the full slot?

No because that actually should say "charging" because its doing that from solar (i.e. not forced by Predbat). On the original table it'll just show an arrow up with a non coloured background, suggesting the same ... "idle" charge or eco mode charge. The coloured ones are planned by predbat (same as the predbat table) - unless you are seeing it green there and white here.

Perhaps what you want to actually see there is just the arrow as you arent using the friendly names.

Just noticed the split slot charge is also the (white) background colour in light mode

Its white because the whole row is white.

pacemaker82 commented 2 months ago

what you want to actually see there is just the arrow as you arent using the friendly names.

Screenshot 2024-05-09 at 10 13 55

Fixed in 1.5.3.6 https://github.com/pacemaker82/PredBat-Table-Card/releases/tag/v1.5.3.6

gcoan commented 2 months ago

thanks, that fixes it. It was indeed a solar charge not a forced charge