coding style checklist - Githubissues

pacew / OpenSC

acos5 working area

https://github.com/pacew/OpenSC/wiki

GNU Lesser General Public License v2.1

4 stars 2 forks source link

coding style checklist #1

Open pacew opened 13 years ago

pacew commented 13 years ago

return expr, not return (expr)
check uses of SC_FUNC_CALLED(p15card->card->ctx, SC_LOG_DEBUG_VERBOSE); and SC_FUNC_RETURN(p15card->card->ctx, SC_LOG_DEBUG_NORMAL, r);
check LOG_DEBUG_VERBOSE vs. LOG_DEBUG_NORMAL
wrap lines at 80 chars
make sure driver functions are static
indenting between type and names of local variables
regularize (non)space between function name and open paren in calls
regularize column 1 start of function names
change printf's to sc_debug's, etc

martinpaljak commented 13 years ago

New code could actually use sc_log and the related macros. The extra verbose SC_LOGDEBUG* symbols just clutter up source code. Also, I'd extend the line wrap to somewhere around 110 or so - most developers these days have (two) widescreen displays. But for a driver it is your call - new code and fixes is supposed to adjust what is around it, yet I'd be personally willing to see commits that change the wrap to more characters rather than fold it into awkward chunks.