pachadotdev / analogsea

Digital Ocean R client
https://pacha.dev/analogsea/
Apache License 2.0
155 stars 24 forks source link

Finish implementation of Spaces API #140

Open amoeba opened 7 years ago

amoeba commented 7 years ago

https://github.com/sckott/analogsea/pull/138 added support for part of the Spaces API and we decided in #136 to start a fresh issue to help divvy up the tasks of completing the API. Below is a checklist with items transcribed from the Spaces API docs:

Let me know if the organization of this list doesn't make sense or isn't useful for tackling this.

amoeba commented 4 years ago

Okay, I can do that.

amoeba commented 4 years ago

I sat down for a few hours tonight to finish up the remaining Spaces functions and ended up getting stumped with what looks like more aws.s3 bugs. Note there are a few more Spaces methods added since the initial go around. I unfortunately don't have any more time before the end of the month to try wrapping things up (so that all Spaces functionality works).

After getting stumped, I spent a bit of time stripping out the aws.s3 parts and trying to make requests from scratch and haven't quite figured it all out, though I must be close.

What do you think makes the most sense as a next step? Sorry I haven't been able to devote more time.

sckott commented 4 years ago

Thanks for the update. I think the additional Spaces work can wait until next version. I'd like to submit by Wed. Do you think the work of replacing aws.s3 can be done by then? If not, I can move the pkg to Suggests and rework so that it's used conditionally.

sckott commented 4 years ago

oh right, you already did that work -> https://github.com/sckott/analogsea/pull/189/

sckott commented 4 years ago

After getting stumped, I spent a bit of time stripping out the aws.s3 parts and trying to make requests from scratch and haven't quite figured it all out, though I must be close.

@amoeba do you think you can finish this today? or should I go ahead and submit?

amoeba commented 4 years ago

No, sorry. Please go ahead and submit. I'll have to carve out some time this quarter.

sckott commented 4 years ago

okay, will do